This repository was archived by the owner on Dec 17, 2024. It is now read-only.
feat: update few DAs references with new values #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocofaigh
requested review from
in-1911
and removed request for
daniel-butler-irl and
ocofaigh
|
added elastic_instance_crn |
in-1911
previously approved these changes
Aug 14, 2024
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
2 similar comments
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
in-1911
reviewed
Aug 16, 2024
stack_definition.json
Outdated
| { | ||
| "name": "elasticsearch_port", | ||
| "value": "ref:./members/3b - Databases for Elasticsearch/outputs/port" | ||
| "value": " ref:../3b - Databases for Elasticsearch/outputs/port" |
There was a problem hiding this comment.
@akocbek - I think you have an extra leading space
|
/run pipeline |
in-1911
approved these changes
Aug 16, 2024
|
🎉 This issue has been resolved in version 0.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
akocbek
added a commit
that referenced
this pull request
Aug 29, 2024
…ort to use existing watsonx services</br> - ES output is used as an input of sample app config DA</br> - watsonx discovery is disabled by default</br> - KMS instances is passed to watsonx and sample app config DA</br> - added support to use existing ES instance</br> - updated the version locator for DAs
akocbek
added a commit
that referenced
this pull request
Sep 2, 2024
…ort to use existing watsonx services</br> - ES output is used as an input of sample app config DA</br> - watsonx discovery is disabled by default</br> - KMS instances is passed to watsonx and sample app config DA</br> - added support to use existing ES instance</br> - updated the version locator for DAs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers