feat: add a new feature to run builds #201
Conversation
|
/run pipeline |
6 similar comments
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
shemau
left a comment
shemau
left a comment
There was a problem hiding this comment.
Thoughts about the architecture of the solution:
app DA only sets up one application.
project DA sets up multiple complex resources.
Architecturally is it better to align with the app approach and introduce an app-from-source (name negotiable) DA that contains a single build.
Both applications from binary and applications from source are similar. Both require a project.
The 'project' DA could exclude builds, or add applications to be balanced.
| description = "A map of code engine builds to be created.[Learn more](https://github.com/terraform-ibm-modules/terraform-ibm-code-engine/blob/main/solutions/project/DA-inputs.md#builds)" | ||
| type = map(object({ | ||
| output_image = string | ||
| output_image = optional(string) |
There was a problem hiding this comment.
This should imply a change to the documentation in the link in the description. The DA now has a more complex interaction between this input and container_resgistry_namespace.
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
solutions/project/main.tf
Outdated
| password = coalesce(secret.data.password, var.ibmcloud_api_key), | ||
| username = coalesce(secret.data.username, "iamapikey"), | ||
| server = coalesce(secret.data.server, local.container_registry) |
There was a problem hiding this comment.
when passing secrets value as-
default = {
my-registry = {
format = "registry"
data = {}
}
}
it is throwing error
│ on main.tf line 143, in locals:
│ 143: password = coalesce(secret.data.password, var.ibmcloud_api_key),
│ ├────────────────
│ │ secret.data is empty map of string
│
│ This map does not have an element with the key "password".
╵
╷
│ Error: Missing map element
│
│ on main.tf line 144, in locals:
│ 144: username = coalesce(secret.data.username, "iamapikey"),
│ ├────────────────
│ │ secret.data is empty map of string
│
│ This map does not have an element with the key "username".
╵
╷
│ Error: Missing map element
│
│ on main.tf line 145, in locals:
│ 145: server = coalesce(secret.data.server, local.container_registry)
│ ├────────────────
│ │ secret.data is empty map of string
│
│ This map does not have an element with the key "server".
as coalesce is looking for the map to exist. Instead we can use lookup to assign the default values.
| password = coalesce(secret.data.password, var.ibmcloud_api_key), | |
| username = coalesce(secret.data.username, "iamapikey"), | |
| server = coalesce(secret.data.server, local.container_registry) | |
| password = lookup(secret.data, "password", var.ibmcloud_api_key), | |
| username = lookup(secret.data, "username", "iamapikey"), | |
| server = lookup(secret.data, "server", local.container_registry) |
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
TestDeployCEProjectDAtest refactoring:- replacedterraform.OutputAllEandterraform.Outputwith own methodgetTerraformOutputto prevent print sensitive outputswriteTfvarsFilefunction to createtfvarsfile and added totemptesting folder to use it instead of CLI vars (prevent print sensitive inputs and solving theError: Can't change variable when applying a saved planissue)New implementation:
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers