Skip to content

Conversation

@Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Jun 23, 2023

Description

  • Added latest available point (current time - 1 day) in PITR test
  • PITR time has to be passed as input if not then earliest_point_in_time_recovery_time will be used as pitr_time

Types of changes in this PR

Changes that affect the core Terraform module or submodules

  • Bug fix
  • New feature
  • Dependency update

Changes that don't affect the core Terraform module or submodules

  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI-related update (pipeline, etc.)
  • Other

Release required?

Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.

Your notes help the merger write the commit message for the PR that is published in the release notes for the module.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 23, 2023

/run pipeline

@shemau shemau self-requested a review June 26, 2023 12:44
shemau
shemau previously requested changes Jun 26, 2023
@Ak-sky
Copy link
Member Author

Ak-sky commented Aug 14, 2023

/run pipeline

@Ak-sky Ak-sky changed the title refactor: pitr_time fix in tests test: pitr_time fix in tests Aug 14, 2023
@Ak-sky Ak-sky requested review from ocofaigh and shemau August 14, 2023 14:46
@ocofaigh
Copy link
Contributor

@Ak-sky I think there is still one issue to be addressed in this PR. Both myself and @shemau have left the same feedback (here and here)

@Ak-sky
Copy link
Member Author

Ak-sky commented Aug 21, 2023

/run pipeline

ocofaigh
ocofaigh previously approved these changes Aug 21, 2023
@ocofaigh
Copy link
Contributor

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Aug 21, 2023

/run pipeline

@Ak-sky Ak-sky requested a review from ocofaigh August 21, 2023 16:38
@ocofaigh ocofaigh dismissed shemau’s stale review August 21, 2023 17:03

All changes addressed

@ocofaigh ocofaigh merged commit 3a11773 into main Aug 21, 2023
@ocofaigh ocofaigh deleted the pitr-test branch August 21, 2023 17:03
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.4.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants