Skip to content

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Aug 29, 2023

Description

Pass description value to ibm_iam_authorization_policy block.

issue : https://github.ibm.com/GoldenEye/issues/issues/5662

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@Khuzaima05 Khuzaima05 self-assigned this Aug 29, 2023
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

@ocofaigh Can I skip the upgrade test here, Pipeline is failing due to this.

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 4, 2023

@Khuzaima05 yes I think this is fine. As per the log, its going to simply update the description of the existing auth policy, so no impact to consumers..

Messages:   	Resource(s) identified to be updated Name: kms_policy Address: module.postgresql_db.ibm_iam_authorization_policy.kms_policy[0] Actions: [update]
        	            	DIFF:
        	            	Before: {"description":null}
        	            	After: {"description":"Allow all ICD Postgres instances in the resource group ee8675e51c5d4ef5aec89b49c5a1b7b5 to read from the kms instance GUID 3082d097-48e5-4adb-b613-77e348d40c89"}

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 requested a review from ocofaigh September 4, 2023 18:58
main.tf Outdated
target_service_name = local.kms_service
target_resource_instance_id = var.existing_kms_instance_guid
roles = ["Reader"]
description = "Allow all ICD Postgres instances in the resource group ${var.resource_group_id} to read from the ${local.kms_service} instance GUID ${var.existing_kms_instance_guid} "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the double space after ${var.resource_group_id}

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment

@Khuzaima05
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit b28258f into main Sep 5, 2023
@ocofaigh ocofaigh deleted the add_description branch September 5, 2023 08:46
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants