Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Nov 27, 2025

Description

Add enable_app_checks and enable_jmx variables to allow users to disable unused features in the Sysdig agent. This addresses GitHub issue #16922 where MongoDB and other app check errors were observed in CDS clusters.

Default values are set to false per Sysdig's recommendation to reduce unnecessary error logs and resource consumption in environments that don't use these features.

Changes:

  • Add enable_app_checks and enable_jmx boolean variables with default=false
  • Configure YAML settings in agent.sysdig.settings for both features
  • Add variables to fully-configurable solution
  • Update ibm_catalog.json with new variable entries

Fixes issue #16922

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 requested a review from Aashiq-J as a code owner November 27, 2025 16:50
@jor2 jor2 self-assigned this Nov 27, 2025
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jor2 what is the default values for these settings? Our module defaults should be the same as the chart defaults. I also left 1 comment

Add enable_app_checks and enable_jmx variables to allow users to disable
unused features in the Sysdig agent. This addresses GitHub issue #16922
where MongoDB and other app check errors were observed in CDS clusters.

Default values are set to true to match the Sysdig agent and chart defaults.
Users can set these to false to reduce error logs and resource consumption
in environments that don't use these features.

Changes:
- Add enable_app_checks and enable_jmx boolean variables with default=true
- Configure YAML settings in agent.sysdig.settings for both features
- Add variables to fully-configurable solution
- Update ibm_catalog.json with new variable entries
- Auto-generate documentation via pre-commit hooks

Fixes issue #16922
@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh ocofaigh merged commit f56f2d8 into main Nov 28, 2025
2 checks passed
@ocofaigh ocofaigh deleted the disable-feature branch November 28, 2025 11:24
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants