Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 1, 2025

The ACL enum values in aws_s3_bucket_invalid_acl.go were ordered inconsistently compared to standard conventions and similar code in the repository.

Changes:

  • Reordered enum list to: private, public-read, public-read-write, authenticated-read, aws-exec-read, bucket-owner-read, bucket-owner-full-control, log-delivery-write
  • Groups common ACLs first, authentication ACLs alphabetically, owner ACLs, then bucket-specific ACL
  • All 8 valid ACL values unchanged, only order modified
enum: []string{
    "private",
    "public-read",
    "public-read-write",
    "authenticated-read",      // moved before aws-exec-read
    "aws-exec-read",
    "bucket-owner-read",
    "bucket-owner-full-control",
    "log-delivery-write",      // moved to end as bucket-specific
}
Original prompt

Please update enum list in rules/aws_s3_bucket_invalid_acl.go


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: wata727 <9624059+wata727@users.noreply.github.com>
Copilot AI changed the title [WIP] Update enum list in rules/aws_s3_bucket_invalid_acl.go Reorder S3 bucket ACL enum values for consistency Nov 1, 2025
Copilot AI requested a review from wata727 November 1, 2025 13:38
Copilot finished work on behalf of wata727 November 1, 2025 13:38
@wata727 wata727 marked this pull request as ready for review November 1, 2025 14:53
@wata727 wata727 enabled auto-merge (squash) November 1, 2025 14:54
@wata727 wata727 merged commit eb4a73a into master Nov 1, 2025
21 checks passed
@wata727 wata727 deleted the copilot/update-enum-list-aws-s3-bucket branch November 1, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants