-
Notifications
You must be signed in to change notification settings - Fork 4
Bug fix so search path order is preserved #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix so search path order is preserved #35
Conversation
Generally, I think we would like to maintain the order in which libraries and paths are added (although I can't think of specific application that I'm currently working on where this is actually important) |
I think this is problematic when it comes to the search paths. I am surprised that there is not a std object that does this. |
|
But there's std::set and std::unordered_set. The former does preserve ordering, but it sorts the entries, I think. Overloading the compare function might allow you to disable the sorting. Or use std::vector |
The std::set iterator is based on the sorted order and not the inserted order which is the issue. It also looks like unordered_set does not iterate based on insertion order. |
55ac60e to
7343f7b
Compare
7343f7b to
2110bbe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 4 2 -2
Lines 189 189
=======================================
Hits 186 186
Misses 3 3
🚀 New features to boost your workflow:
|
When debugging PR #34 I found that std::set does not preserve order which I believe is not what we want for the search paths and library names. @marip8 do you agree?