Skip to content

Improve couchbase container startup resilience#2076

Closed
rnorth wants to merge 2 commits intomasterfrom
couchbase-resilience
Closed

Improve couchbase container startup resilience#2076
rnorth wants to merge 2 commits intomasterfrom
couchbase-resilience

Conversation

@rnorth
Copy link
Member

@rnorth rnorth commented Nov 16, 2019

Wait before CouchbaseContainer setup is run to reduce risk of apparent partial configuration/race conditions, and increase general wait strategy timeout.

Also add trace level logging, used in diagnosis and possibly useful in
future.

Possible fix for #1453.

Currently running tests repeatedly to determine whether this has truly gone away.

to reduce risk of apparent partial configuration/race conditions

Also add trace level logging, used in diagnosis and possibly useful in
future

Possible fix for #1453
@daschl
Copy link
Member

daschl commented Nov 16, 2019

@rnorth so based on your debugging it is because the config is sent before the rest api is available?

@rnorth
Copy link
Member Author

rnorth commented Nov 16, 2019

I believe it may be. As-is, I don't think it looks safe, and after making this change I'm not able to reproduce the errors I was seeing.

I think I'm going to need to repeat tests on a less powerful machine than I'm using right now; the failure rate seems to be higher on slower machines (which suggests a race condition).

@rnorth
Copy link
Member Author

rnorth commented Nov 16, 2019

Damn, I was mistaken - running this on a slower machine still results in failures, so this is not a solution.

Still, I'd like to go ahead with this PR as it improves the error logging a little, and I don't see waiting for the REST API to be available before calling it to be a bad thing.

Sorry for getting peoples' hopes up though.

@rnorth
Copy link
Member Author

rnorth commented Nov 28, 2019

#2106 improved our test stability, though #1453 really should remain open until the module itself can be made more resilient.

We don't need this PR immediately, and I expect this to become irrelevant when @daschl comes back with findings on stabilising the module. As such, I'll close this particular PR.

@rnorth rnorth closed this Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants