phantomjs runner executes my tests twice

[jerodsanto]

I'm on Rails 3.2.13 and using the asset pipeline. My jasmine.yml looks like this:

spec_files:
  - "**/*[Ss]pec.{js,coffee}"

I am testing an Angular controller that looks like this:

//= require angular
//= require angular-mocks
//= require application/app
//= require application/controllers/nav_ctrl

describe("NavCtrl", function() {
  // ... snip ...
})

(the reason for the 'application' directory inside 'javascripts/assets' is because there are more than one Angular apps in the Rails app)

When I run rake spec:javascript the phantomjs runner executes my "NavCtrl" tests twice.

I noticed that the generated spec/tmp/runner.html has a script tag for each of my dependencies and my spec files and it also includes a jasmine-specs.js file which appears to be all of the dependencies and spec files concatenated into a single file.

When I visit /specs in my app everything works okay (runs once) and the included jasmine-specs.js file is empty.

Any ideas what could be going on?

Thanks!

[searls]

This strikes me as requiring live debugging to identify the cause. Can you prepare a minimal sample project? Unless @wireframe has an idea?

[wireframe]

can you check your asset pipeline settings for development/test? specifically, the assets.debug flag. try flipping it to false (the default) and re-run the specs

config.assets.debug = false

[jerodsanto]

@wireframe I set config.assets.debug to false in my development environment and it fixed the problem! This begs two questions:

1. Shouldn't the test environment be in effect when running Jasmine specs, not the development environment?
2. Why does having this setting set to true (the default on a newly generated 3.2.13 app) cause this problem?

[searls]

Both very valid questions.

[jerodsanto]

So turning of assets debugging in dev mode is pretty annoying. I confirmed that explicitly running the specs in test mode, eg:

RAILS_ENV=test rake spec:javascript

fixes the 'run twice' behavior. This is most likely because asset debugging is disabled by default in test mode.

Having the specs run in test mode by default makes a lot of sense to me. Alternatively, fixing how jasmine-specs.js is generated also makes a lot of sense to me.

Thoughts?

[searls]

Either way, 👍 to flipping test mode on for that rake task.

[searls]

Can anyone find a decent example of how one's supposed to favor the test environment from a rake task that inherits from :environment? I couldn't find one.

[floehopper]

I'm still seeing this issue in v0.4.5. It works fine if I use RAILS_ENV=test rake spec:javascript, but not if I don't set the environment to test i.e. I'm not convinced 7f00190 fixed the problem. Note that I'm using Rails v4.0.0.

[searls]

Yep, this is a regression caused by how Rails 4 preloads the Rails environment for every executed task. I've asked several people and received zero productive comments on how to work around it.

For now, just use RAILS_ENV=test. If we can't find a way to wrangle the Rails environment, I think a new release should probably just eschew rake altogether and include a CLI bin for jasmine-rails.

[floehopper]

Cool. Thanks for letting me know.

[searls]

I'm still pretty stumped about how to flip Rails environment after Rake starts. I've heard from multiple people that it's not possible anymore.

Please Internet, you're my only hope

[wireframe]

@searls I think the key to fixing this issue is to not depend on :environment in the rake task declaration. The environment task is triggered to load the current Rails environment (which defaults to development) and afterwards, you won't be able to change back into test mode.

Instead, you should be able to define the task with no dependencies, manually set the RAILS_ENV environment variable, and then programmatically trigger the :environment task to load the rest of the Rails environment.

Here's a gist as an example, but I have not tested it yet to confirm that it works as expected.
https://gist.github.com/wireframe/6581238

[searls]

I spiked this but what I found was that rails' env is preloaded as of rails 4 in such a way that it doesn't matter whether we depend on the :environment. Did you test your spike to verify it works on rails 4?

On Mon, Sep 16, 2013 at 10:18 AM, Ryan Sonnek notifications@github.com
wrote:

@searls I think the key to fixing this issue is to not depend on :environment in the rake task declaration. The environment task is triggered to load the current Rails environment (which defaults to development) and afterwards, you won't be able to change back into test mode.
Instead, you should be able to define the task with no dependencies, manually set the RAILS_ENV environment variable, and then programmatically trigger the :environment task to load the rest of the Rails environment.
Here's a gist as an example, but I have not tested it yet to confirm that it works as expected.

https://gist.github.com/wireframe/6581238

Reply to this email directly or view it on GitHub:
#28 (comment)