Skip to content

Conversation

@juliusdelta
Copy link
Contributor

@juliusdelta juliusdelta commented Sep 18, 2019

What: The README.md was outdated with the cy.get(All)By* commands that were removed and replaced with an error in favor of cy.find(All)By*.

Why: Just to make documentation and use more clear for users of the repo.

How: README.md updates

Checklist:

  • Documentation
    - [ ] Tests
  • Ready to be merged

If y'all would like I can open up an issue on testing-library docs for someone else to grab and reference this one so they can get an OSS contribution.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 931abec into testing-library:master Sep 18, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @juliusdelta for docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @juliusdelta! 🎉

@kentcdodds
Copy link
Member

@all-contributors please add @afontcu for review

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @afontcu! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants