Skip to content

Conversation

darekkay
Copy link
Contributor

@darekkay darekkay commented Jun 3, 2020

What:

Update @types/testing-library__jest-dom dependency to the latest version.

Why:

TypeScript doesn't recognize the new toBeEmptyDOMElement API from #254 after upgrading the @testing-library/jest-dom package in a project (see also the discussion).

Checklist

  • Documentation N/A
  • Tests N/A
  • Updated Type Definitions
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          309       309           
  Branches        73        73           
=========================================
  Hits           309       309           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5272f...985a091. Read the comment docs.

@gnapse
Copy link
Member

gnapse commented Jun 4, 2020

Note: CI build passed, but apparently something got stuck along the way to reflect that on this page.

I'm merging as is.

@gnapse gnapse merged commit 159a7a2 into testing-library:master Jun 4, 2020
@gnapse
Copy link
Member

gnapse commented Jun 11, 2020

🎉 This PR is included in version 5.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants