fix: jest preset was not working

Author: Brandon Carroll

jest-preset.js

@@ -5,5 +5,5 @@ module.exports = Object.assign(jestPreset, {
     ...jestPreset.transformIgnorePatterns,
     'node_modules/(?!(react-native.*|@?react-navigation.*)/)',
   ],
-  setupFilesAfterEnv: [require.resolve('./dist/preset/setup.js')],
+  setupFiles: [...jestPreset.setupFiles, require.resolve('./dist/preset/setup.js')],
 });

src/__tests__/events.js

@@ -86,34 +86,34 @@ test('calling a custom event works as well', () => {
   });
 });
 
-test('calling a handler when there is no valid target throws', () => {
+test('calling a handler when there is no valid target does not work', () => {
   const handleEvent = jest.fn();
   const { getByTestId } = render(<Image onPress={handleEvent} testID="image" />);
-  expect(() => fireEvent.press(getByTestId('image'))).toThrow();
+  expect(() => fireEvent.press(getByTestId('image'))).not.toThrow();
   expect(handleEvent).toBeCalledTimes(0);
 });
 
-test('calling a handler if a Button is disabled throws', () => {
+test('calling a handler if a Button is disabled does not work', () => {
   const handleEvent = jest.fn();
   const { getByText } = render(<Button disabled onPress={handleEvent} title="button" />);
-  expect(() => fireEvent.press(getByText('button'))).toThrow();
+  expect(() => fireEvent.press(getByText('button'))).not.toThrow();
   expect(handleEvent).toBeCalledTimes(0);
 });
 
-test('calling a handler if a Touchable is disabled throws', () => {
+test('calling a handler if a Touchable is disabled does not work', () => {
   const handleEvent = jest.fn();
   const { getByText } = render(
     <TouchableHighlight disabled onPress={jest.fn()}>
       <Text>touchable</Text>
     </TouchableHighlight>,
   );
-  expect(() => fireEvent.press(getByText('touchable'))).toThrow();
+  expect(() => fireEvent.press(getByText('touchable'))).not.toThrow();
   expect(handleEvent).toBeCalledTimes(0);
 });
 
 test('calling an event that has no defined handler throws', () => {
   const { getByText } = render(<Text>test</Text>);
-  expect(() => fireEvent.press(getByText('test'))).toThrow();
+  expect(() => fireEvent.press(getByText('test'))).not.toThrow();
 });
 
 test('calling an event sets nativeEvent properly', () => {

src/lib/__tests__/to-json.js

@@ -22,7 +22,7 @@ test('it converts to json', () => {
       <View>
         <MiddleComponent>hello</MiddleComponent>
         <View>
-          <Text>world</Text>
+          <Text onPress={jest.fn()}>world</Text>
           <Text>foo bar</Text>
         </View>
         <View />

src/lib/events.js

@@ -202,22 +202,14 @@ function isDisabled(element) {
 
 function findEventHandler(element, event) {
   const { typeArg } = event;
-  const eventHandler = getEventHandlerName(typeArg);
-  const valid = isValidTarget(element, event);
-  const disabled = isDisabled(element);
-
-  if (typeof element.props[eventHandler] === 'function' && valid) {
-    if (disabled) {
-      throw new Error(`A target was found for event: "${typeArg}", but the target is disabled`);
-    }
-    return element.props[eventHandler];
-  }
+  const handlerName = getEventHandlerName(typeArg);
+  const eventHandler = element.props[handlerName];
 
-  if (element.parent === null) {
-    throw new Error(`No target found for event: "${typeArg}"`);
+  if (eventHandler && !isDisabled(element) && isValidTarget(element, event)) {
+    return eventHandler;
   }
 
-  return findEventHandler(element.parent, event);
+  return element.parent ? findEventHandler(element.parent, event) : i => i;
 }
 
 function fireEvent(element, event) {

src/lib/query-helpers.js

@@ -60,7 +60,7 @@ function proxyUnsafeProperties(node) {
         return function(...args) {
           return ref
             .apply(this, args)
-            .filter(node => validComponentFilter(node))
+            .filter(validComponentFilter)
             .map(proxyUnsafeProperties);
         };
       } else if (key === 'getProp') {

src/lib/to-json.js

@@ -27,12 +27,20 @@ function toJSON(node) {
       return renderedChildren;
     }
 
+    // Function props get noisy in debug output, so we'll exclude them
+    let renderedProps = {};
+    Object.keys(props).filter(name => {
+      if (typeof props[name] !== 'function') {
+        renderedProps[name] = props[name];
+      }
+    });
+
     // Finally, create the JSON object
     return {
       $$typeof: Symbol.for('react.test.json'),
       parent: node.parent,
       type: node.type,
-      props,
+      props: renderedProps,
       children: renderedChildren,
     };
   } catch (e) {