Skip to content
This repository was archived by the owner on Aug 6, 2025. It is now read-only.

Conversation

jrolfs
Copy link
Member

@jrolfs jrolfs commented Sep 1, 2022

Refactors extracted from #488 to clean up the diff:

  • Isolate 'standard' page (no timeout) in describe block so that both standard and deferred page tests have beforeEach and afterEach to open and close the page
  • Rename SupportedQueries to SynchronousQueries in preparation to support find* queries
  • Use queries from Testing Library to enumerate queries (instead of internal hard-coded query name array, with the intention of removing all of the legacy ElementHandle implementation in a future major release)

@jrolfs jrolfs changed the base branch from main to beta September 1, 2022 06:15
@jrolfs jrolfs requested a review from sebinsua September 1, 2022 06:18
@jrolfs jrolfs self-assigned this Sep 1, 2022
@jrolfs jrolfs merged commit 43a2716 into beta Sep 1, 2022
@jrolfs jrolfs deleted the refactor/query-for-and-test-describe branch September 1, 2022 06:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant