This repository was archived by the owner on Aug 6, 2025. It is now read-only.
🐛 Support function text matchers in queries #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebinsua
reviewed
Sep 22, 2022
| @@ -1,5 +1,6 @@ | |||
| const replacer = (_: string, value: unknown) => { | |||
| if (value instanceof RegExp) return `__REGEXP ${value.toString()}` | |||
| if (typeof value === 'function') return `__FUNCTION ${value.toString()}` | |||
Collaborator
There was a problem hiding this comment.
As a follow-up, we should probably document that this won't work for closures.
sebinsua
approved these changes
Sep 22, 2022
Playwright dropped support for Node 12 in a non-breaking release, but it's leaving LTS soon anyways.
jrolfs
force-pushed
the
fix/support-function-text-match
branch
from
cfb59d4 to
480ce66
Compare
|
🎉 This PR is included in version 4.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our types incorrectly claimed support for function
TextMatch. This change actually adds support for that.