chore(deps): update typescript to v3 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested changes
Mar 11, 2020
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
thanks very much @abraham!
Updated wait-for-expect to fix resolve import lint complaint
oof, really wish we could've batched this with the previous breaking change 😆I'm not sure it's worth shipping another major for lint issues. Maybe we only ignore the lint error for now instead?
Contributor
Author
|
Maybe this should be bundled with #7 as I think that has a major update to |
Collaborator
By "this" do you mean the I still think we can do the typescript upgrade. |
Contributor
Author
|
Yep, I'll update this PR later tonight. |
Contributor
Author
|
@patrickhulce updated |
patrickhulce
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait-for-expectto fix resolve import lint complaint