Skip to content

chore: add tests for Node 16 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: add tests for Node 16 #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ language: node_js
notifications:
email: false
node_js:
- '10'
- '12'
- '14'
- 10
- 12
- 14
Copy link
Member

@nickserv nickserv Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 15 is still supported until June 1

Suggested change
- 14
- 14
- 15

Copy link
Member Author

@MichaelDeBoey MichaelDeBoey Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't support odd Node versions, only when they're latest

Copy link
Member

@nickserv nickserv Apr 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand from Node's LTS schedule, 15 is actually still supported right now, even though 16 (which will eventually be upgraded to an LTS) has been released since. Technically 16 is the only latest release here anyway.

- 16
script: npm run validate
jobs:
include:
Expand Down