fix: fire event init #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JoviDeCroock
approved these changes
Jun 8, 2022
Member
JoviDeCroock
left a comment
JoviDeCroock
left a comment
There was a problem hiding this comment.
Renamed your PR so semantic release can pick it up well :D this looks great, thank you!
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Preact specific
fireEventis broken: fixes #61Why:
fireEventAPI is broken after preact specific changesHow:
Updated existing event tests to demonstrate the regression, fixed the tests by adding init to the preact specific
fireEventChecklist:
I'm not entirely sure how the type definitions work for the methods that are inherited from other testing-library libraries, so not sure if anything needs to be done so I marked it as N/A. These changes should bring the
fireEventin the preact library more in line withfireEventfrom dom.