Update React Redux recipe to use custom render with wrapper #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkrolick
reviewed
Apr 4, 2020
docs/example-react-redux.md
Outdated
| <div> | ||
| <button onClick={this.decrement}>-</button> | ||
| <span data-testid="count-value">{this.props.count}</span> | ||
| <h1>{this.props.count}</h1> |
Collaborator
There was a problem hiding this comment.
h1 after h2? Let's leave this alone.
Member
Author
There was a problem hiding this comment.
My bad, missed it sorry.. Will fix.
Member
Author
There was a problem hiding this comment.
@alexkrolick Fixed it, thanks..
Also refactored the class component to a functional one in the current time spirit :)
kentcdodds
reviewed
Apr 6, 2020
Member
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Looks good to me! Just one thing.
docs/example-react-redux.md
Outdated
Comment on lines
91
to
93
| import { fireEvent, screen } from '@testing-library/react' | ||
| // We're using our own custom render function and not RTL's render | ||
| import { render } from './test-utils.js |
Member
There was a problem hiding this comment.
In accordance with the setup suggestions, this should be:
Suggested change
| import { fireEvent, screen } from '@testing-library/react' | |
| // We're using our own custom render function and not RTL's render | |
| import { render } from './test-utils.js | |
| // We're using our own custom render function and not RTL's render | |
| // our custom utils also re-export everything from RTL | |
| // so we can import fireEvent and screen here as well | |
| import { render, fireEvent, screen } from './test-utils.js |
Member
Author
There was a problem hiding this comment.
Updated it and also added the export to the test-utils.js file..
Thanks!
Member
|
@all-contributors please add @MatanBobi for docs |
Contributor
|
I've put up a pull request to add @MatanBobi! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the React Redux recipe to use a custom
renderwith thewrapperoption.Also refactored the class component to a functional component.
This PR is following the talk with @kentcdodds in this PR.