Skip to content

Conversation

@camjackson
Copy link
Contributor

I currently have this PR open in svelte-jester to make it a bit clearer how to get svelte-testing-library to play nice with TypeScript.

Assuming that that gets merged (or something like it), I thought it would be good to add a reference to TypeScript here in the testing-library docs, just so the breadcrumbs are a little easier to follow for a newbie setting up svelte-testing-library who is also using TypeScript. That's what this PR does 🙂

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@kentcdodds
Copy link
Member

Ah, could you resolve the conflicts here please?

@camjackson
Copy link
Contributor Author

camjackson commented Aug 3, 2020

Oh, um, the merge conflict was actually with someone else who had the same idea. #542 added added inline instructions for how to get typescript to work, but they're a bit incomplete based on the discussion we had over in the svelte-jester issues.

So to resolve the conflict what I've done is remove the specific instructions that were added here in #542, and replaced them with just a reference to go and read the svelte-jester docs, seeing as those are more complete and will hopefully stay up to date with any changes to svelte-jester.

I feel a little bit bad for deleting work that someone else just did, but I feel like this is a better solution. Happy to discuss 🙂

@mihar-22
Copy link
Contributor

mihar-22 commented Aug 3, 2020

Looks good and as discussed I think this is much better. Thanks for all your help again :)

@mihar-22 mihar-22 merged commit 2fb2cd4 into testing-library:master Aug 3, 2020
@mihar-22
Copy link
Contributor

mihar-22 commented Aug 3, 2020

@all-contributors please add @camjackson for docs

@allcontributors
Copy link
Contributor

@mihar-22

I've put up a pull request to add @camjackson! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants