Skip to content

Conversation

@vxxce
Copy link
Contributor

@vxxce vxxce commented May 15, 2021

Corrects broken footer link to "API".
Resolves #847

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also add a redirect so that existing links outside of our control to https://testing-library.com/docs/dom-testing-library/api-queries still work?

@MatanBobi
Copy link
Member

@eps1lon I believe we already have a redirect for that page:
https://github.com/testing-library/testing-library-docs/blob/main/netlify.toml#L58

If you agree, I think we can merge this! :)
Thanks @vxxce!

@eps1lon
Copy link
Member

eps1lon commented May 15, 2021

@eps1lon I believe we already have a redirect for that page:
https://github.com/testing-library/testing-library-docs/blob/main/netlify.toml#L58

Right, I always get confused that redirects do not apply to on-page navigation. Only when landing 😕

Edit:
I think we should go through every redirect and check if a link in the docs applies.

@vxxce
Copy link
Contributor Author

vxxce commented May 15, 2021

EDIT: looks like @MatanBobi beat me to it!

Looks like there is an existing re-direct from docs/dom-testing-library/api-queries to /docs/queries/about:

[[redirects]]
from = "/docs/dom-testing-library/api-queries"
to = "/docs/queries/about"

I do wonder if it might be better to redirect the "api-queries" endpoint to docs/dom-testing-library/api (as in e7279f6) rather than docs/queries/about. I.e:

[[redirects]]
  from = "/docs/dom-testing-library/api-queries"
  to = "/docs/dom-testing-library/api"

Given the possible ambiguity in the url, it makes sense to me to link them to the core-api page, from which there is a direct link to queries if that was the context in which it was linked to externally. Kind of catches all possible intentions. I'm happy to commit that suggestion if you there's agreement about that.

And if I'm missing something re: that re-direct already existing, let me know! Thanks.

@MatanBobi
Copy link
Member

MatanBobi commented May 23, 2021

I think we should go through every redirect and check if a link in the docs applies.

@eps1lon I went over the redirects we had there and found one broken, I opened a PR

@MatanBobi MatanBobi merged commit 6c12e9a into testing-library:main May 23, 2021
@MatanBobi
Copy link
Member

Thanks @vxxce!

@MatanBobi
Copy link
Member

@all-contributors please add @vxxce for docs :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @vxxce! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footer link to API points at wrong uri

3 participants