-
Notifications
You must be signed in to change notification settings - Fork 734
Corrects the location pointed to by broken footer "API" link. Fixes #… #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eps1lon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you also add a redirect so that existing links outside of our control to https://testing-library.com/docs/dom-testing-library/api-queries still work?
|
@eps1lon I believe we already have a redirect for that page: If you agree, I think we can merge this! :) |
Right, I always get confused that redirects do not apply to on-page navigation. Only when landing 😕 Edit: |
|
EDIT: looks like @MatanBobi beat me to it!
testing-library-docs/netlify.toml Lines 57 to 59 in b818032
I do wonder if it might be better to redirect the "api-queries" endpoint to Given the possible ambiguity in the url, it makes sense to me to link them to the core-api page, from which there is a direct link to queries if that was the context in which it was linked to externally. Kind of catches all possible intentions. I'm happy to commit that suggestion if you there's agreement about that. And if I'm missing something re: that re-direct already existing, let me know! Thanks. |
|
Thanks @vxxce! |
|
@all-contributors please add @vxxce for docs :) |
|
I've put up a pull request to add @vxxce! 🎉 |
Corrects broken footer link to "API".
Resolves #847