Add warning message to fireEvent input and change when called directly #83 #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 70 74 +4
Branches 13 15 +2
=========================================
+ Hits 70 74 +4
Continue to review full report at Codecov.
|
|
Hi, thanks for this! I gave this some more thought and now I wonder what would happen for people using Vue Testing Lib + user-event… 🤔 |
|
@afontcu I could add some test cases for user-event. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made an assumption here that whenever we get a second arg, it's coming from a direct call but would be happy to change it if it's an incorrect assumption. Let me know what y'all think!