Breaks on environment variables with newlines

[tesujimath]

As described in nix-community/home-manager#4313 (comment)

Problem is easy to reproduce:

aya$ echo "export tEsT='mult
iline'"| bash-env-json
jq: parse error: Expected separator between values at line 2, column 7

and it is because of this:

aya$ echo -n 'mult
iline'| jq -R
"mult"
"iline"

which is easy to fix:

aya$ echo -n 'mult
iline'| jq -Rs
"mult\niline"

[tesujimath]

Fix coming imminently ...

[jaredmontoya]

@tesujimath
Are there any other edge cases that bash-env module is better at handling than this modified version of capture-foreign-env that now uses NUL bytes instead of newlines like bash-env-json here

# Returns a record of changed env variables after running a non-nushell script's contents (passed via stdin), e.g. a bash script you want to "source"
def capture-foreign-env [
  --shell (-s): string = /bin/sh
  # The shell to run the script in
  # (has to support '-c' argument and POSIX 'env', 'echo', 'eval' commands)
  --arguments (-a): list<string> = []
  # Additional command line arguments to pass to the foreign shell
] {
  let script_contents = $in;
  let env_out = with-env { SCRIPT_TO_SOURCE: $script_contents } {
    ^$shell ...$arguments -c `
    env -0
    echo -n '<ENV_CAPTURE_EVAL_FENCE>'
    eval "$SCRIPT_TO_SOURCE"
    echo -n '<ENV_CAPTURE_EVAL_FENCE>'
    env -0 -u _ -u _AST_FEATURES -u SHLVL` # Filter out known changing variables
  }
  | split row '<ENV_CAPTURE_EVAL_FENCE>'
  | {
    before: ($in | first | str trim --char (char -i 0) | split row (char -i 0))
    after: ($in | last | str trim --char (char -i 0) | split row (char -i 0))
  }

  $env_out.after
  | where { |line| $line not-in $env_out.before } # Only get changed lines
  | parse "{key}={value}"
  | transpose --header-row --as-record
}

[tesujimath]

@jaredmontoya Hmm, I am unsure. bash-env-json is certainly more complex, but it does also handle plain shell variables and shell functions.

I didn't really have a good look at yours, sorry.