Problems with take ALL and drop ALL (5.8 beta)

[KVonGit]

Default behavior

You are in a room.
You can see a table (on which there is a basket (containing a bag (containing a ball))).

> get all
basket: You pick it up.
bag: You pick it up.
ball: You pick it up.

> drop all
basket: You drop it.
bag: You drop it.
ball: You drop it.

> undo
Undo: drop all

> undo
Undo: get all

> l
You are in a room.
You can see a table (on which there is a basket (containing a bag (containing a ball))).

> get basket
You pick it up.

> i
You are carrying a basket (containing a bag (containing a ball)).

> drop all
basket: You drop it.
bag: You are not carrying it.
ball: You are not carrying it.

---

My "fixes"

EDIT This is no good!

This may not be the best way to handle this, but it seems to work VERY well UNLESS directly dealing with an object in a held container.

---

Take

if (multiple and ListCount(object) = 0) {
 msg ("Nothing here to take.")
}
else {
 foreach (obj, object) {
   if (not ListContains(GetAllChildObjects(game.pov),obj)) {
     DoTake (obj, multiple)
   }
 }
}

---

Drop

if (multiple and ListCount(object) = 0) {
  msg ("You are not carrying anything.")
}
else {
  foreach (obj, object) {
    if (obj.parent = game.pov) {
      DoDrop (obj, multiple)
    }
  }
}

---

You are in a room.
You can see a table (on which there is a basket (containing a bag (containing a ball))).

> get all
basket: You pick it up.

> i
You are carrying a basket (containing a bag (containing a ball)).

> drop all
basket: You drop it.

> i
You are not carrying anything.

> l
You are in a room.
You can see a table and a basket (containing a bag (containing a ball)).

> get all
basket: You pick it up.

> i
You are carrying a basket (containing a bag (containing a ball)).

> l
You are in a room.
You can see a table.

> put basket on table
Done.

> i
You are not carrying anything.

> l
You are in a room.
You can see a table (on which there is a basket (containing a bag (containing a ball))).

[KVonGit]

UPDATE

My "fixes" don't print anything when trying to take an object from inside of a held container.

[KVonGit]

NOTE

I think this is how GET ALL should behave. It's how it behaves in Inform, TADS and most Infocom games.

...but everyone else on the forum seemed to disagree. (I can't find the old thread.)

[ThePix]

I think the drop script is fine. Here is a take script; see how it looks to you. Works for me.

if (multiple and ListCount(object) = 0) {
  msg ("Nothing here to take.")
}
else {
  foreach (obj, object) {
    // if this is multiple then we should skip anything in a container that will be taken
    // and anything held by an NPC
    if (not multiple or (not obj.parent.take and not DoesInherit(obj.parent, "npc_type"))) {
      DoTake (obj, multiple)
    }
  }
}

This is the thread:
http://textadventures.co.uk/forum/quest/topic/pl1aur8l3usk2lrn_rzy1g/meaning-of-take-all-and-drop-all

See also:
https://www.intfiction.org/forum/viewtopic.php?f=6&t=26137&sid=ce7d6e41a03e6386325475824da3bce9

[KVonGit]

Does this not happen to you when holding a container with child objects?

> i
You are carrying a basket (containing a bag (containing a ball)).

> drop all
basket: You drop it.
bag: You are not carrying it.
ball: You are not carrying it.

[ThePix]

Sorry, I meant the drop script you have above, not the one in the beta.

[KVonGit]

Put an egg in a basket. Pick up the basket. Enter DROP EGG. (There is no response and nothing happens.)

[KVonGit]

These 2 (it's the same TAKE) seem to work fine:

  <command name="take">
    <pattern>take #object#; get #object#; pick up #object#</pattern>
    <allow_all />
    <scope>notheld</scope>
    <script>
      if (multiple and ListCount(object) = 0) {
        msg ("Nothing here to take.")
      }
      else {
        foreach (obj, object) {
          // if this is multiple then we should skip anything in a container that will be taken
          // and anything held by an NPC
          if (not multiple or (not obj.parent.take and not DoesInherit(obj.parent, "npc_type"))) {
            DoTake (obj, multiple)
          }
        }
      }
    </script>
  </command>

REMOVED BAD Take CODE

[KVonGit]

Sorry, that ignored objects in objects which were held!

This seems foolproof (which can't be true, can it?):

  <command name="drop">
    <pattern>drop #object#</pattern>
    <allow_all />
    <scope>inventory</scope>
    <script>
      if (multiple and ListCount(object) = 0) {
        msg ("You are not carrying anything.")
      }
      else {
        foreach (obj, object) {
          if (Contains(game.pov,obj)) {
            DoDrop (obj, multiple)
          }
        }
      }
    </script>
  </command>

[ThePix]

DROP ALL:

That looks good. I was worried that an item that appears in the game file before the container would be listed before the container in object, but that is not the case, so this works as it should.

[ThePix]

I have uploaded a modified CoreCommands to Github. I have also modified it so the blocking message is customisable (as a good way to give NPC items is to have the NPC as a transparent container); in a later version I will add something to the editor for that too.

[KVonGit]

Sounds like this Issue is [SOLVED]!

[KVonGit]

Sorry to reopen this.

I have a table in a room. It is a surface (of course). I consider the table a backdrop. Being that it doesn't make sense to try to take the table, the table is not_all.

Now, I have an object on the table which SHOULD be included in TAKE ALL.

This TAKE works as I expect:

  <command name="take">
    <pattern>take #object#; get #object#; pick up #object#</pattern>
    <allow_all />
    <scope>notheld</scope>
    <script>
      if (multiple and ListCount(object) = 0) {
        msg ("Nothing here to take.")
      }
      else {
        foreach (obj, object) {
          // if this is multiple then we should skip anything in a container that will be taken
          // and anything held by an NPC
          if (not multiple or (not obj.parent.take and not DoesInherit(obj.parent, "npc_type"))) {
            DoTake (obj, multiple)
          }
        }
      }
    </script>
  </command>

---

The new TAKE (which is currently in CoreCommands) ignores the items on my table.