Sanitize remote variables and fix recent forum post list #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gocom
commented
Mar 1, 2019
gocom
commented
- Fixes persistent XSS vulnerabilities.
- Fixes recent forum posts list.
- Cleans unnecessary variable naming; the blocks are evaluated in separate function context and do not collide.
This fixes potential of persistent XSS attacks. Also fixes fetching forum topics and corrects the validation logic. Cleans unnecessary variable naming; the blocks are evaluated in separate function context and do not collide.
gocom
changed the title
Member
|
This is great, thank you very much @gocom. I'll merged this and the other PR into the code and put live. My PHP skills are pretty much zero so I appreciate any help given there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.