Sanitize remote variables used in the language table #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also prevent the whole page from breaking on a XML parsing error due to an exception not being caught.
gocom
changed the title
Member
|
Thanks again @gocom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also prevent the whole page from breaking on a XML parsing error due to an exception not being caught. The language ID was removed due to security too; user-given values (like these remote values are) are not safe to be used as a IDs and would need to be filtered properly before use.
As I do not have a API key for the said service (and its lazy Friday night) the code is untested, but should function just fine.