Skip to content

Conversation

@BobSilent
Copy link
Collaborator

In case of work item updated event, provide the workitem change information to rules
this enables the rules to be executed in case of a dedicated change,
For Example, run only if

  • Title was changed
  • Story Points were updated
  • A Child link was added or removed

@giuliov
Copy link
Member

giuliov commented Aug 21, 2019

Thanks for all the hard work.
I have only two comments, one aesthetic and one functional.

A name like selfUpdate doesn't sounds natural, more a verb than a noun. Maybe changes works better?
The other remarks is the nullability of this object: there are default values for all properties, so why bother with nulls?

Looking for your reply before merging.

@BobSilent
Copy link
Collaborator Author

BobSilent commented Aug 22, 2019

You are right, I will adapt both.

With the naming I was also struggling but selfChanges sound much better, I just aligned to WorkItemUpdate class name.
I would stick to the prefix self, as the changes are the changes of self. also the event itself provides the workItem and workItemUpdates so it is all in all alligned.
what do you think?

Also it should not be null, I did it inside the wrapper but selfChanges should not be null as well.
Therefore I need to update the documentation as well

I will update pull request soon

@giuliov giuliov merged commit 00a2e5c into tfsaggregator:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants