New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jsonb columns to be created with the schema builder #500

Merged
merged 1 commit into from Sep 29, 2014

Conversation

Projects
None yet
4 participants
@bendrucker
Collaborator

bendrucker commented Sep 22, 2014

@tgriesser Will leave this for you to merge since I haven't spent much time with the column compiler in the past

Closes #499

@jpdesigndev

This comment has been minimized.

jpdesigndev commented Sep 22, 2014

Wow, that was super quick. Thank you!

tgriesser added a commit that referenced this pull request Sep 29, 2014

Merge pull request #500 from tgriesser/jsonb
Allow jsonb columns to be created with the schema builder

@tgriesser tgriesser merged commit eeb3b36 into master Sep 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@tgriesser tgriesser deleted the jsonb branch Sep 29, 2014

@naturalethic

This comment has been minimized.

naturalethic commented Oct 14, 2014

Was this supposed to add support for returning objects instead of strings on jsonb columns?

@bendrucker

This comment has been minimized.

Collaborator

bendrucker commented Oct 14, 2014

No. It's just for schema purposes. node-postgres handles converting json columns to objects.

@naturalethic

This comment has been minimized.

naturalethic commented Oct 14, 2014

Ok, thanks.

@naturalethic

This comment has been minimized.

naturalethic commented Oct 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment