This repository was archived by the owner on May 21, 2022. It is now read-only.
Android automatic refactor - ViewHolder#340
Merged
a-r-db merged 1 commit intosimple-last-fm-scrobbler:masterfrom May 21, 2018
luiscruz:autorefactor-viewholder
Merged
Android automatic refactor - ViewHolder#340a-r-db merged 1 commit intosimple-last-fm-scrobbler:masterfrom luiscruz:autorefactor-viewholder
a-r-db merged 1 commit intosimple-last-fm-scrobbler:masterfrom
luiscruz:autorefactor-viewholder
Conversation
|
Refactoring is always welcome, hope this gets reviewed and merged ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am developing a tool to automatically refactor Android applications with the goal of improving energy efficiency.
This pull request has the changes generated while applying the rule "ViewHolder".
When developing list views, it is very common to repeat work in every item. Something very common is retrieving a field with the API method
findViewById. There is a ViewHolder pattern that lets you reuse the work made in the previous computed item.I have made a previous validation of the changes and they seem correct.
Please consider them and let me know if you agree with them.
Best,
Luis