Skip to content

Conversation

@IsQiao
Copy link
Contributor

@IsQiao IsQiao commented Jun 6, 2023

Fix some error links and commands

Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IsQiao :))
Can you please sign the DCO and then we can merge?

Govt
Hint: git commit --amend --signoff

@IsQiao
Copy link
Contributor Author

IsQiao commented Jun 6, 2023

Thanks @IsQiao :)) Can you please sign the DCO and then we can merge?

Govt Hint: git commit --amend --signoff

fixed it.

@squat
Copy link
Member

squat commented Jun 6, 2023

It looks like it's still failing. Is it possible that you signed with the wrong email address?

Signed-off-by: qinxiaowen <qxwxintu@gmail.com>
@IsQiao
Copy link
Contributor Author

IsQiao commented Jun 6, 2023

fixed it.

@squat
Copy link
Member

squat commented Jun 6, 2023

Thanks :)

@squat squat merged commit e43900e into thanos-io:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants