Day 21: GCD with floats on codefights #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabagawee
reviewed
May 1, 2017
day21/helpingStephan.py
Outdated
| YdigitsAfterDecimal = ySplit[1] | ||
|
|
||
|
|
||
| digitsAfterDecimal = max(len(XdigitsAfterDecimal), len(YdigitsAfterDecimal)) |
There was a problem hiding this comment.
instead of doing all this work, why not use the problem description where it says "It is guaranteed that both x and y will have at most 5 digits after the decimal point."
day21/helpingStephan.py
Outdated
|
|
||
| r = -1 | ||
| while r != 0: | ||
| r = round(a % b, 6) * 1.0 |
There was a problem hiding this comment.
do you need to do floating point math here? since you multiplied x and y by a power of 10 to make them effectively integers, can't you just run gcd in its integer form?
Owner
Author
There was a problem hiding this comment.
I need the rounding but not the float coercion actually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please comment, critique, and discuss! The more you explain your thoughts, the faster I can update / discuss / and learn :)
Thanks!