Skip to content

SSH port forward #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2023
Merged

SSH port forward #938

merged 2 commits into from
Sep 1, 2023

Conversation

@bummoblizard
Copy link
Member

@bummoblizard bummoblizard commented Aug 31, 2023 •
edited
Loading

Fixes #764.

Todos:

  • Fix a bug in NMSSH where socket didCloseUnexpectedly is not called when a socket is closed
  • Refine the protocols
  • Fix a bug where side bar is stuck at progress view infinitely if port forward is the last opened section
  • Localisation
  • Port forward setup persistence

@bummoblizard bummoblizard force-pushed the ssh-portforward branch 2 times, most recently from 4a38775 to ea19b0b Compare September 1, 2023 05:03
@bummoblizard bummoblizard changed the title wip: SSH port forward SSH port forward Sep 1, 2023
bummoblizard
bummoblizard commented Sep 1, 2023
View reviewed changes
CodeApp/Managers/FileSystem/PortForwardServiceProvider.swift Outdated
case forward(Address, Address)
}

protocol PortForwardSocket: Identifiable {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Identifiable

@bummoblizard
Copy link
Member Author

Let's deal with persistence in #928.

@bummoblizard bummoblizard merged commit eaf003a into thebaselab:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement ssh port forwarding

1 participant

@bummoblizard