Skip to content

Pass Python Executable Path To CMake #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

Pass Python Executable Path To CMake #12

merged 1 commit into from
Nov 9, 2023

Conversation

@brianmichel
Copy link

@brianmichel brianmichel commented Nov 9, 2023 •
edited
Loading

Description

We have to make sure we pass the Python executable path to CMake as this is a step that is done by the build scripts which firebase supplies. If we are not going to use them we have to ensure that we do this step manually.

Testing

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@brianmichel Graphite App
Copy link
Author

brianmichel commented Nov 9, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@brianmichel brianmichel mentioned this pull request Nov 9, 2023
Closed
3 tasks
@brianmichel brianmichel changed the title Ensure we pass our python path to CMake Pass Python Executable Path To CMake Nov 9, 2023
@brianmichel brianmichel marked this pull request as ready for review November 9, 2023 11:15
@brianmichel brianmichel requested a review from compnerd November 9, 2023 11:15
@brianmichel brianmichel mentioned this pull request Nov 9, 2023
Closed
3 tasks
compnerd
compnerd approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@brianmichel
Copy link
Author

brianmichel commented Nov 9, 2023

Looks like the build passed, (arm64 support doesn't exist yet, so that build should fail).

@brianmichel brianmichel merged commit af01005 into compnerd/swift Nov 9, 2023
@brianmichel brianmichel deleted the brian/pass-python-path-to-cmake branch November 9, 2023 12:04
kendalharland pushed a commit that referenced this pull request May 8, 2024
@brianmichel
Ensure we pass our python path to CMake (#12)
60757b6
kendalharland pushed a commit that referenced this pull request May 8, 2024
@brianmichel
Ensure we pass our python path to CMake (#12)
2187872
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
59e8318
bcny-fork-syncer bot pushed a commit that referenced this pull request May 25, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
eeb0944
bcny-fork-syncer bot pushed a commit that referenced this pull request May 31, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
68d4e30
bcny-fork-syncer bot pushed a commit that referenced this pull request Jun 1, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
018c7d5
bcny-fork-syncer bot pushed a commit that referenced this pull request Jun 7, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
f8bcc1d
bcny-fork-syncer bot pushed a commit that referenced this pull request Jul 16, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
50624c9
bcny-fork-syncer bot pushed a commit that referenced this pull request Jul 18, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
ec4b3f0
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 3, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
f5f3193
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 6, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
a504225
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 21, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
800b696
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 7, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
c059196
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 11, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
00bcfc4
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 12, 2024
@brianmichel @kendalharland
Ensure we pass our python path to CMake (#12)
d36abb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianmichel @compnerd