Override build settings to specify /Z7 instead of /Zi for embedded PDBs in the BCNY windows build #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Mar 5, 2024
tristanlabelle
approved these changes
Mar 5, 2024
kendalharland
pushed a commit
that referenced
this pull request
May 8, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
kendalharland
pushed a commit
that referenced
this pull request
May 8, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
May 25, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
May 31, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jun 1, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 7, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…Bs in the BCNY windows build (#20) * [windows][build] add a helper script to adjust MSVC debug flags to be Z7 instead of Zi * [bcny][gh workflow] build firebase with /Z7 for embedded debug information on windows * roll back to the mainline branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change modifies the way the Nuget package builds for windows. It forces the C++ and C flags to specify
/Z7instead of/Zifor MSVC, which embeds the debug info PDBs into the object files.Testing
Build the SDK and used these libraries to build a downstream project.