[cmake] Target AXV2 ISA when building for AMD64 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Mar 28, 2024
Collaborator
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Does it make sense to use -D CMAKE_CXX_FLAGS="/arch:AVX2" -D CMAKE_C_FLAGS="/arch:AVX2"?
Member
Author
Are you asking if it's better to use |
|
Would it make sense (or feasible) to do this in https://github.com/thebrowsercompany/firebase-cpp-sdk/blob/compnerd/swift/.github/workflows/bcny-firebase.yml instead? I had the impression that our local bcny changes are concentrated in that file. |
Collaborator
|
More what @hjyamauchi was getting at - add that as flags to the command line invocation in the GHA yaml to avoid modifying the upstream package. I want to try to get as close to the upstream state for the package so that we can easily continue to rebase the package. |
compnerd
approved these changes
Mar 28, 2024
hjyamauchi
approved these changes
Mar 28, 2024
added 2 commits
March 29, 2024 15:37
Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context.
kendalharland
force-pushed
the
kendal/devin-1142-add-a-ceiling-cpu-version-to-arc-compiler-invocations
branch
from
fcdc032 to
3186990
Compare
kendalharland
deleted the
kendal/devin-1142-add-a-ceiling-cpu-version-to-arc-compiler-invocations
branch
kendalharland
pushed a commit
that referenced
this pull request
May 7, 2024
This reverts commit a37ec70.
kendalharland
added a commit
that referenced
this pull request
May 7, 2024
kendalharland
added a commit
that referenced
this pull request
May 8, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
kendalharland
added a commit
that referenced
this pull request
May 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
May 25, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
May 31, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jun 1, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 7, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
* [cmake] Target AXV2 ISA when building for AMD64 Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context. * Make changes in bcny-firebase.yml instead of CMakeLists.txt --------- Co-authored-by: kendal <kendal@thebrowser.company>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Targeting AXV2 is the closest we can get to targeting Haswell when compiling with msvc. See DEVIN-1142 for more context.
Type of Change
Place an
xthe applicable box: