-
Notifications
You must be signed in to change notification settings - Fork 0
Disable C++ exception handling for windows builds #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
compnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I wonder if this is going to cause some trouble. We do not enable exceptions when importing into Swift, and so this can cause ABI differences here. I think that we should disable exceptions: /EHsc- and then tell the C++ runtime to sod off (there is a macro for disabling exceptions).
|
|
|
Updated to disable exception handling. Thanks for the flag. |
compnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it builds, LGTM!
|
I'm curious why this wasn't an issue before. LGTM. |
|
Likely due to bad build system setup by Google, I suspect that they are modifying |
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
* Enable C++ standard exception handling for windows build * Disable exception handling altogether --------- Co-authored-by: kendal <kendal@thebrowser.company>
This should fix an error in the windows CI builds: