Build storage and functions #26
Conversation
|
I think this is sufficient but also not sure how to validate this. Would appreciate any guidance. Thanks! |
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
I don't remember if we need to manually trigger the new build - so if it doesn't get another build out after this is merged, we might need to trigger it manually before you can update the consumer of the nuget.
I think that the best way to validate this might be to do a one-off CI run of the build and check the nuget contents. Its not a great solution, but it at least should give you some level of confidence. Might be worthwhile to trigger CI runs on Windows as well for future changes. WDYT @darinf? |
That all sounds good, but ... I'm not sure how to do so. Any pointers? |
Maybe it is this: 
|
|
Yes, you can manually trigger the job from the actions tab and selecting the job. |
Cool, unfortunately it seems to have failed: I'm struggling to see any error in that log output though :-/ |
|
Thanks. I've kicked off a build of |
compnerd/swift is an unrelated experiment to implement a swift compiler pre-OSS. Did you mean the base repository? It might be more interesting to test this repository without your change (basically run the build at main), as that would tell us if the builds are currently working or not right? |
Ah, OK. I just guessed at what branch to base my PR on. The instructions here: https://github.com/thebrowsercompany/swift-firebase?tab=readme-ov-file say to take the latest release from https://github.com/thebrowsercompany/firebase-cpp-sdk/tags, which appears to be a build off of |
Oh! I see what you were saying - you were referring to the branch name not the repository name. Yes, that is the right branch to try to build at! |
Looks like it also fails the Same issue: |
|
Seems like a recent regression then :(. Not sure what has happened here, but would need someone to investigate and fix before we can resume the builds (I'm currently tied up in a few things). |
I think that something is not right earlier in the environment resulting in the configure step mis-configuring CURL and thus causing the subsequent failure. |
darinf
force-pushed
the
darin/build-storage-and-functions
branch
from
40e719f to
5890332
Compare
kendalharland
force-pushed
the
compnerd/swift
branch
from
46990b8 to
08b0c11
Compare
darinf
force-pushed
the
darin/build-storage-and-functions
branch
from
5890332 to
630e908
Compare
|
Do we know why |
This remains a mystery. Haven't fully tested this. I will be back here if things don't work out properly. |
OK, yes... Will explore how to get it properly included into the nuget package. |
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
- Adds `FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}` defines to the `cmake` build.
- Includes corresponding header files in the nuget package.
- Includes generated libs in the nuget package.
- Removes `upb.lib` which appears to no longer be generated.
Changes:
FIREBASE_INCLUDE_{FUNCTIONS,STORAGE}defines to thecmakebuild.upb.libwhich appears to no longer be generated.