Skip to content

Trigger the firebase workflow on pull requests #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2024
Merged

Trigger the firebase workflow on pull requests #28

merged 1 commit into from
May 9, 2024

Conversation

@kendalharland
Copy link
Member

@kendalharland kendalharland commented May 7, 2024 •
edited
Loading

Description

Removes a footgun where the PR author may trigger this workflow incorrectly when testing a PR.

Changes

  • Make sure this workflow clones the PR branch's version of the code by removing the hardcoded reference to compnerd/swift
  • Add on.pull_request event trigger
  • Skip nuget package actions/upload step if the event is workflow_dispatch.
  • Skip nuget package publish step if the event is workflow_dispatch.

Testing

The workflow is now running as part of this PR's presubmit

Type of Change

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@kendalharland kendalharland force-pushed the kendal/devin-1298-trigger-the-correct-set-of-ci-workflows-on-firebase-cpp-sdk branch from 3980ab9 to 13ae78f Compare May 7, 2024 23:17
darinf
darinf approved these changes May 7, 2024
View reviewed changes
Copy link

@darinf darinf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

hjyamauchi
hjyamauchi reviewed May 7, 2024
View reviewed changes
hjyamauchi
hjyamauchi reviewed May 8, 2024
View reviewed changes
@kendalharland kendalharland force-pushed the kendal/devin-1298-trigger-the-correct-set-of-ci-workflows-on-firebase-cpp-sdk branch from 49b26e3 to 7fdd653 Compare May 8, 2024 00:50
@kendalharland kendalharland force-pushed the kendal/devin-1298-trigger-the-correct-set-of-ci-workflows-on-firebase-cpp-sdk branch from 7fdd653 to 0867b6c Compare May 8, 2024 23:54
@kendalharland
Copy link
Member Author

kendalharland commented May 8, 2024

Rebased on top of #30

@kendalharland kendalharland force-pushed the kendal/devin-1298-trigger-the-correct-set-of-ci-workflows-on-firebase-cpp-sdk branch from 0867b6c to c3190e4 Compare May 9, 2024 17:23
[gha][firebase] Run on pull_request
5fe1268 
Skip actions/upload for nuget pkg when workflow_dispatch
@kendalharland kendalharland force-pushed the kendal/devin-1298-trigger-the-correct-set-of-ci-workflows-on-firebase-cpp-sdk branch from c3190e4 to 5fe1268 Compare May 9, 2024 17:25
@kendalharland kendalharland merged commit 782b123 into compnerd/swift May 9, 2024
@kendalharland kendalharland deleted the kendal/devin-1298-trigger-the-correct-set-of-ci-workflows-on-firebase-cpp-sdk branch May 9, 2024 18:17
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
4226b19 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request May 25, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
9891c00 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request May 31, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
009afcb 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Jun 1, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
ad3476d 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Jun 7, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
b65fbfb 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Jul 16, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
3f2bbec 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Jul 18, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
f0284bf 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 3, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
fca36b8 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 6, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
5418528 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Aug 21, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
55f2f21 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 7, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
4e37a04 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 11, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
bdd9de0 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
bcny-fork-syncer bot pushed a commit that referenced this pull request Sep 12, 2024
@kendalharland
[gha][firebase] Run on pull_request (#28)
5c90a98 
Skip actions/upload for nuget pkg when workflow_dispatch

Co-authored-by: kendal <kendal@thebrowser.company>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjyamauchi hjyamauchi hjyamauchi approved these changes

@compnerd compnerd compnerd approved these changes

+1 more reviewer

@darinf darinf darinf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kendalharland @compnerd @darinf @hjyamauchi