fix: optimize InView #392
Merged
fix: optimize InView #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/the-builder/react-intersection-observer/rff0h9dc9 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0c360d:
|
Owner
Author
|
🎉 This PR is included in version 8.28.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the rendering flow in the
<InView>component, optimizing it for the children.Previously it had a an internal
stateused to store the currentinViewandentryvalues. But it was only really used by the component when using the render props pattern. This lead to unnecessary renders for the plain component.Another optimization tried to limit the state updates, so it would only occur if
inViewchanged. This however meant you wouldn't get the correctentryvalue in the render prop, since it would only update wheninViewchanges. This would prevent you from getting the latestthresholdorisVisiblevalues.