Refactoring to use SchemaFactory #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No services are injected in @FieldMiddlewarePipe. As a result, the @Logged and @right annotations are broken. We might gain some stability by migrating to SchemaFactory usage in the bundle. This PR starts with a failing test. Closes thecodingmachine#18
So far, the bundle declared all instances manually, duplicating the role of the SchemaFactory. In time, this lead to various issues like thecodingmachine#18. This PR refactors the bundle to use the SchemaFactory. This will lead to less duplicated code and therefore less bugs. Also, it drastically improves the code coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the bundle declared all instances manually, duplicating the role of the SchemaFactory.
In time, this lead to various issues like #18.
This PR refactors the bundle to use the SchemaFactory. This will lead to less duplicated code and therefore less bugs.
Also, it drastically improves the code coverage.
Closes #18