Skip to content

Fixing union type exception message when types are not "named" #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Fixing union type exception message when types are not "named" #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Mappers/CannotMapTypeException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ public static function createForParseError(Error $error): self
*/
public static function createForBadTypeInUnion(array $unionTypes): self
{
$disallowedTypes = array_filter($unionTypes, static function (Type $type) {
return $type instanceof NamedType;
});
$disallowedTypeNames = array_map(static function (NamedType $type) {
return $type->name;
}, $disallowedTypes);

return new self('In GraphQL, you can only use union types between objects. These types cannot be used in union types: ' . implode(', ', $disallowedTypeNames));
$disallowedTypeNames = array_map(static function (Type $type) {
if ($type instanceof NamedType) {
return $type->name;
}
return (string) $type;
}, $unionTypes);

return new self('in GraphQL, you can only use union types between objects. These types cannot be used in union types: ' . implode(', ', $disallowedTypeNames));
}

public static function mustBeOutputType(string $subTypeName): self
Expand Down
2 changes: 1 addition & 1 deletion tests/Mappers/Parameters/TypeMapperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function testMapScalarUnionException(): void
$docBlockObj = $cachedDocBlockFactory->getDocBlock($refMethod);

$this->expectException(CannotMapTypeException::class);
$this->expectExceptionMessage('In GraphQL, you can only use union types between objects. These types cannot be used in union types: Int, String');
$this->expectExceptionMessage('in GraphQL, you can only use union types between objects. These types cannot be used in union types: Int, String');
$typeMapper->mapReturnType($refMethod, $docBlockObj);
}

Expand Down