Skip to content

Conversation

@Kharhamel
Copy link
Contributor

@Kharhamel Kharhamel commented Aug 31, 2020

  • : add a separate workflow to test the different bundles
  • : add a separate workflow to generate the doc

@Kharhamel Kharhamel force-pushed the actionCi branch 3 times, most recently from 28c41a6 to e75e9ea Compare August 31, 2020 14:42
@Kharhamel Kharhamel changed the title WIP: deleted scrutinizer conf WIP: improved the action ci Aug 31, 2020
@Kharhamel Kharhamel force-pushed the actionCi branch 3 times, most recently from 03774a0 to ecb5675 Compare September 1, 2020 11:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #298   +/-   ##
=========================================
  Coverage     99.39%   99.39%           
  Complexity     1532     1532           
=========================================
  Files           137      137           
  Lines          3495     3495           
=========================================
  Hits           3474     3474           
  Misses           21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3383b4...f445ff0. Read the comment docs.

@Kharhamel Kharhamel changed the title WIP: improved the action ci improved the action ci Sep 1, 2020
Copy link
Member

@moufmouf moufmouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little changes and I'm good to merge this.

#todo: verify this always works
#todo: use a matrix syntax?

name: "Test the bundles' dependancies"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Test the bundles' dependancies"
name: "Test the bundles' dependencies"

@@ -0,0 +1,80 @@
# test for breaking changes on the different bundle projects
#todo: verify this always works
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#todo: verify this always works

@Kharhamel Kharhamel merged commit f1ac731 into thecodingmachine:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants