Adding support for PHP 8 attributes #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bonus, parameter related attributes can now be added as parameter attributes (instead of method anotations)
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
============================================
+ Coverage 99.39% 99.42% +0.02%
- Complexity 1533 1582 +49
============================================
Files 137 137
Lines 3496 3630 +134
============================================
+ Hits 3475 3609 +134
Misses 21 21
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PHP 8 attributes in addition to Doctrine annotations.
The PHP class for the Doctrine Annotation and the PHP Attribute is the same.
For attributes related to parameters, they have been migrated to parameter attributes (rather than method annotations with a "for" keyword).
Caveat: could not migrate annotations in annotations (cause this is not possible with attributes)