Removing parameters that have been removed from PHP before 7.1 #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar #61 for parameters
When a parameter is removed (ie.
$is_dst
inmktime
cf http://fr2.php.net/manual/fr/function.mktime.php) calling the method with more parameter than allowed triiger a warning likeError Warning: mktime() expects at most 6 parameters, 7 given
This PR ignore such parameters.
note: In the future if the project supports several major version in parallel, it will have to be able to generate different code for each running version.