Fix build for Apple Clang #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecppzoo
approved these changes
Dec 24, 2023
Owner
thecppzoo
left a comment
thecppzoo
left a comment
There was a problem hiding this comment.
Thanks!
This code is not completely operational, I assure you Scott and I have been working on the SWAR library to come back to finish this
Collaborator
Author
|
Great! Pls lmk if there is anything else about this PR you'd like to see changed before you merge! Looks like I can't do it on my side :) |
Owner
Don't you have permission? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some type inference issues on Apple Clang, also cleaned up a few spots using
sprintfas opposed tosnprintf.