Skip to content

Conversation

@guumaster
Copy link
Contributor

This PR mainly change tests and no app code, it includes:

  • updated almost all npm dependencies (mongdb 2.x needs a bigger refactor)
  • simplified mocha tests to avoid exporting tests
  • added root hooks for mocha to start/stop server
  • remove some unused packages and files
  • added the possibility to override port config with environment variables
  • changed indentation of package.json (npm rewrites it with spaces and not tabs)

@luismesas
Copy link
Member

@guumaster eres contribuidor del proyecto, please haz las pullrequest desde la rama en el cipherlayer principal en vez de tu fork ya que si no tengo que duplicar tus PR para que ciecleci comparta las variables de entorno durante los tests.

Tienes mas info aqui: https://circleci.com/docs/fork-pr-builds

@guumaster
Copy link
Contributor Author

👍 cierto, la costumbre de hacerlo en el fork. Cierro este.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants