Skip to content

Conversation

@MateoWartelle
Copy link
Contributor

Summarize the changes made and the motivation behind them.

documentation page for the FileInput Component to match Flowbite website

Reference related issues using # followed by the issue number.

If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 1:36am

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 487 lines in your changes are missing coverage. Please review.

Comparison is base (7461173) 99.54% compared to head (8bf04c1) 93.59%.
Report is 104 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
- Coverage   99.54%   93.59%   -5.95%     
==========================================
  Files         163      184      +21     
  Lines        6621     8093    +1472     
  Branches      401      447      +46     
==========================================
+ Hits         6591     7575     +984     
- Misses         30      518     +488     
Files Coverage Δ
src/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/components/Banner/index.ts 100.00% <100.00%> (ø)
src/components/Breadcrumb/theme.ts 100.00% <100.00%> (ø)
src/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/components/Button/ButtonBase.tsx 100.00% <100.00%> (ø)
src/components/Button/theme.ts 100.00% <100.00%> (ø)
src/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/components/Carousel/Carousel.tsx 99.10% <100.00%> (+0.13%) ⬆️
src/components/DarkThemeToggle/DarkThemeToggle.tsx 100.00% <100.00%> (ø)
src/components/Datepicker/index.ts 100.00% <100.00%> (ø)
... and 49 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateoWartelle MateoWartelle marked this pull request as draft September 25, 2023 00:52
@rluders
Copy link
Collaborator

rluders commented Sep 25, 2023

@MateoWartelle isn't the FileInput documented here already? https://flowbite-react-git-fork-mateowartelle-docs-fileinput-themesberg.vercel.app/docs/components/forms#file-upload

Anyway, I think that we could separate all the docs for the forms components like the standard flowbite library does:

image

WDYT? @zoltanszogyenyi what would be the SEO impact here? Do we need to keep some redirects?

@zoltanszogyenyi
Copy link
Member

@rluders the SEO impact is good because people also search for "file input", "search input" and so on. It shouldn't affect the content on the forms page, it's okay to have some duplicates especially if the content is different (the paragraphs). Whatever is on flowbite.com is already SEO proof:

General forms page:

https://flowbite.com/docs/components/forms/

Standalone input pages:

https://flowbite.com/docs/forms/input-field/
https://flowbite.com/docs/forms/file-input/
https://flowbite.com/docs/forms/search-input/

Cheers,
Zoltan

@MateoWartelle MateoWartelle marked this pull request as ready for review September 26, 2023 12:36
@rluders
Copy link
Collaborator

rluders commented Sep 27, 2023

@MateoWartelle I know that it is probably a little bit "out of scope" for this PR, but since we moved the FileInput component to forms/... Do you mind making the same change for all other form-components?

@MateoWartelle
Copy link
Contributor Author

@MateoWartelle I know that it is probably a little bit "out of scope" for this PR, but since we moved the FileInput component to forms/... Do you mind making the same change for all other form-components?

Yes I think that is best.

@MateoWartelle MateoWartelle mentioned this pull request Sep 30, 2023
2 tasks
@MateoWartelle MateoWartelle mentioned this pull request Oct 1, 2023
2 tasks
@SutuSebastian
Copy link
Collaborator

maybe we should bring this back to life, but with the new docs engine changes. The code here can be just for parts-and-pieces to import into the main branch, one form component at a time 🤔

@MateoWartelle
Copy link
Contributor Author

maybe we should bring this back to life, but with the new docs engine changes. The code here can be just for parts-and-pieces to import into the main branch, one form component at a time 🤔

Yes I think so too. I started with the checkbox one and should be easy to do the others.

@MateoWartelle MateoWartelle deleted the docs/FileInput branch November 14, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants