feat!: Improve the FileSystemTestCase #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the usage by no longer requiring to implement an abstract method.
A significant (internal, but observable) change is that we no longer use a namespaced directory. Indeed, instead of having:
We now have:
Indeed, the creation of the temporary directory is already thread safe, so there is no need for the user to implement an abstract method. And because of it, we can remove the usage of a namespace which is not that useful and if anything may mess up the thread safety.