Skip to content

Assign WebACL from the inlined component in a single run #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Assign WebACL from the inlined component in a single run #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cloudfront.cfndsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

export = external_parameters.fetch(:export_name, external_parameters[:component_name])

Condition('WebACLEnabled', FnNot(FnEquals(Ref('WebACL'), ''))) # WebACL issue part, works well without this condition
Condition('OverrideAliases', FnNot(FnEquals(Ref('OverrideAliases'), '')))

tags = []
Expand Down Expand Up @@ -108,7 +107,7 @@
distribution_config[:Enabled] = external_parameters[:enabled]
distribution_config[:IPV6Enabled] = ipv6 unless ipv6.nil?
distribution_config[:PriceClass] = Ref('PriceClass')
distribution_config[:WebACLId] = FnIf('WebACLEnabled', Ref('WebACL'), Ref('AWS::NoValue')) # WebACL issue part
distribution_config[:WebACLId] = Ref('WebACL')
distribution_config[:CustomErrorResponses] = custom_error_responses unless custom_error_responses.nil?

logs = external_parameters.fetch(:logs, {})
Expand Down Expand Up @@ -392,4 +391,4 @@

end

end
end