Skip to content

adds support for enabling data tiering #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

adds support for enabling data tiering #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e869ee0
adds support for enabling data tiering
aaronwalker Oct 21, 2024
3667a82
fatty fingers
aaronwalker Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions redis.cfhighlander.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@
description: 'The number of clusters this replication group initially has'
end

ComponentParam 'DataTieringEnabled', 'false', allowedValues: ['false', 'true'],
description: 'Enables DataTiering and requires InstanceType to be a r6gd type'

end

end
4 changes: 4 additions & 0 deletions redis.cfndsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@
replication_mode = external_parameters.fetch(:replication_mode, 'node_group')
automatic_failover = external_parameters.fetch(:automatic_failover, true)

Condition('DataTieringEnabled', FnEquals(Ref(:DataTieringEnabled), 'true'))

engine = external_parameters.fetch(:engine, 'redis')

ElastiCache_ReplicationGroup(:ReplicationGroupRedis) {
Expand All @@ -94,6 +96,8 @@
AutoMinorVersionUpgrade minor_upgrade
AutomaticFailoverEnabled automatic_failover

DataTieringEnabled FnIf('DataTieringEnabled', Ref(:DataTieringEnabled), Ref('AWS::NoValue'))

CacheNodeType Ref(:InstanceType)
CacheParameterGroupName Ref(:ParameterGroupRedis)
CacheSubnetGroupName Ref(:SubnetGroupRedis)
Expand Down
1 change: 1 addition & 0 deletions spec/cache-cluster_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"CacheNodeType" => {"Ref"=>"InstanceType"},
"CacheParameterGroupName" => {"Ref"=>"ParameterGroupRedis"},
"CacheSubnetGroupName" => {"Ref"=>"SubnetGroupRedis"},
"DataTieringEnabled" => {"Fn::If"=>["DataTieringEnabled", {"Ref"=>"DataTieringEnabled"}, {"Ref"=>"AWS::NoValue"}]},
"Engine" => "redis",
"NumCacheClusters" => {"Ref"=>"NumCacheClusters"},
"ReplicationGroupDescription" => {"Fn::Sub"=>"${EnvironmentName}-redis"},
Expand Down
1 change: 1 addition & 0 deletions spec/clustered_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"CacheNodeType" => {"Ref"=>"InstanceType"},
"CacheParameterGroupName" => {"Ref"=>"ParameterGroupRedis"},
"CacheSubnetGroupName" => {"Ref"=>"SubnetGroupRedis"},
"DataTieringEnabled" => {"Fn::If"=>["DataTieringEnabled", {"Ref"=>"DataTieringEnabled"}, {"Ref"=>"AWS::NoValue"}]},
"Engine" => "redis",
"NumNodeGroups" => {"Ref"=>"NumNodeGroups"},
"Port" => 1234,
Expand Down
1 change: 1 addition & 0 deletions spec/default_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"CacheNodeType" => {"Ref"=>"InstanceType"},
"CacheParameterGroupName" => {"Ref"=>"ParameterGroupRedis"},
"CacheSubnetGroupName" => {"Ref"=>"SubnetGroupRedis"},
"DataTieringEnabled" => {"Fn::If"=>["DataTieringEnabled", {"Ref"=>"DataTieringEnabled"}, {"Ref"=>"AWS::NoValue"}]},
"Engine" => "redis",
"NumNodeGroups" => {"Ref"=>"NumNodeGroups"},
"ReplicasPerNodeGroup" => {"Ref"=>"ReplicasPerNodeGroup"},
Expand Down
1 change: 1 addition & 0 deletions spec/node-group_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"CacheNodeType" => {"Ref"=>"InstanceType"},
"CacheParameterGroupName" => {"Ref"=>"ParameterGroupRedis"},
"CacheSubnetGroupName" => {"Ref"=>"SubnetGroupRedis"},
"DataTieringEnabled" => {"Fn::If"=>["DataTieringEnabled", {"Ref"=>"DataTieringEnabled"}, {"Ref"=>"AWS::NoValue"}]},
"Engine" => "redis",
"NumNodeGroups" => {"Ref"=>"NumNodeGroups"},
"ReplicasPerNodeGroup" => {"Ref"=>"ReplicasPerNodeGroup"},
Expand Down
1 change: 1 addition & 0 deletions spec/non-clustered_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"CacheNodeType" => {"Ref"=>"InstanceType"},
"CacheParameterGroupName" => {"Ref"=>"ParameterGroupRedis"},
"CacheSubnetGroupName" => {"Ref"=>"SubnetGroupRedis"},
"DataTieringEnabled" => {"Fn::If"=>["DataTieringEnabled", {"Ref"=>"DataTieringEnabled"}, {"Ref"=>"AWS::NoValue"}]},
"Engine" => "redis",
"NumNodeGroups" => {"Ref"=>"NumNodeGroups"},
"ReplicasPerNodeGroup" => {"Ref"=>"ReplicasPerNodeGroup"},
Expand Down
Loading