Skip to content

Support 'bazel mod tidy'#64

Merged
thm-automation[bot] merged 2 commits intomainfrom
me/tidy
Nov 5, 2024
Merged

Support 'bazel mod tidy'#64
thm-automation[bot] merged 2 commits intomainfrom
me/tidy

Conversation

@mark-thm
Copy link
Copy Markdown
Contributor

@mark-thm mark-thm commented Nov 5, 2024

Add support for running bazel mod tidy.

@thm-automation thm-automation bot enabled auto-merge (squash) November 5, 2024 03:20
@thm-automation thm-automation bot merged commit 4d435b7 into main Nov 5, 2024
@thm-automation thm-automation bot deleted the me/tidy branch November 5, 2024 14:03
@alexeagle
Copy link
Copy Markdown

It seems like this broke the ability to have only dev_dependency on rules_multitool:

ERROR: root_module_direct_deps must be empty if the root module contains no usages with dev_dependency = False
ERROR: error evaluating module extension multitool in @@rules_multitool~//multitool:extension.bzl

@mark-thm
Copy link
Copy Markdown
Contributor Author

@alexeagle does #70 fix this for you?

@alexeagle
Copy link
Copy Markdown

@mark-thm yeah thanks, looks good at bazel-contrib/rules_oci#770 (note that I'm doing a naughty lookup of a canonical repo name, which looks like the name is changed in your fix)

@mark-thm
Copy link
Copy Markdown
Contributor Author

@alexeagle I'm not sure why the canonical repo name would change

@mark-thm
Copy link
Copy Markdown
Contributor Author

oh I see, it's from an earlier update where we do a repo per tool/arch rather than one per arch.

@alexeagle
Copy link
Copy Markdown

sorry I should have been more clear the delta here was from 0.9.0 yes. Thanks!

apalmer-theorem pushed a commit that referenced this pull request Mar 18, 2025
Re:
#64 (comment)

Co-authored-by: Mark Elliot <markelliot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants